[Merge] ~cpete/ubuntu-seeds/+git/ubuntu:jammy-no-openssh-server into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:jammy

[Utkarsh Gupta]

> So the commit does add ssh-import-id to the cloud-image
> seed, but you're saying the CPC images don't use the
> cloud-image seed? Or, the minimized image uses the
> server-minimal seed instead? If it's the latter then we
> should probably add a minimal-cloud seed and change the
> builders accordingly. Happy to help make that happen but
> I don't know where that code is for CPC, which relates
> to my next question.

No - from live-build/auto/config:

  ubuntu-cpc)
    KERNEL_FLAVOURS=virtual

    if [ "${SUBPROJECT:-}" = minimized ]; then
      add_task install cloud-image
      add_package install sudo lxd-installer
    else
      add_task install minimal standard cloud-image
      add_package install ubuntu-minimal
            case $ARCH in
        armhf|arm64|ppc64el|powerpc)
          add_task install server
          ;;
      esac
    fi

So the cloud-image seed is not used as a metapackage but via the package tagging mechanism. If a package has a cloud-image task tagged then it'll get installed when running add_task in the install layer.

For the base images (non-minimized images), we use the server task, which I think takes in both, server and server-minimal contents? So we should really test that both, minimized and non-minimized, images have ssh-import-id package in them and that add_task mechanism.


> Could you elaborate on what kind of testing you're
> looking for please? I've done some tests to make sure
> this change causes the meta packages to be updated as
> I expect them to be, but otherwise I don't know what
> further testing we can do without building the images
> (with the changes) first.

Sorry but metapackages won't cut it. How did you check the metapackages to be updated when there's none for cloud-image? :)

We'd like to ensure the CPC minimized and non-minimized images, with this seed change, still have the package available. We use ubuntu-bartender (https://github.com/ubuntu-bartenders/ubuntu-old-fashioned/) for that. A sample command would be:

$ ubuntu-bartender --build-provider gce --hook-extras-dir "$(pwd)/cpc_packaging.extra" --livecd-rootfs-branch ubuntu/jammy -- --series jammy --project ubuntu-cpc --image-target qcow2 --subproject minimized 

Let me/us know if you need any more context or help. 
-- 
https://code.launchpad.net/~cpete/ubuntu-seeds/+git/ubuntu/+merge/468628
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:jammy.