[Merge] ~utkarsh/livecd-rootfs/+git/livecd-rootfs:install-lxd-from-diff-channel into livecd-rootfs:ubuntu/master

Steve Langasek mp+451786 at code.launchpad.net
Fri Sep 22 05:30:46 UTC 2023


Review: Needs Fixing



Diff comments:

> diff --git a/live-build/auto/build b/live-build/auto/build
> index 08b42a2..2e13576 100755
> --- a/live-build/auto/build
> +++ b/live-build/auto/build
> @@ -317,8 +317,9 @@ fi
>  echo "Removing lxd installer package..."
>  apt-get purge -y lxd-installer
>  
> -echo "Installing lxd from snap..."
> -snap install lxd
> +. /etc/os-release
> +echo "Installing lxd from snap from stable/ubuntu-$(VERSION_ID) channel"
> +snap install --channel="stable/ubuntu-$(VERSION_ID)" lxd

VERSION_ID: command not found
should be ${VERSION_ID} or simply $VERSION_ID

>  EOF
>  		fi
>  		cat >> chroot/usr/local/sbin/unminimize <<'EOF'


-- 
https://code.launchpad.net/~utkarsh/livecd-rootfs/+git/livecd-rootfs/+merge/451786
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list