[Merge] ~mwhudson/livecd-rootfs/+git/livecd-rootfs:language-support-in-catalogs into livecd-rootfs:ubuntu/master

Sebastien Bacher mp+408855 at code.launchpad.net
Thu Sep 23 13:41:26 UTC 2021


Review: Needs Information

Thanks, the code seems fine but I've some questions on the intended design. Checking subiquity it seems the locale_support key isn't used yet? Do you have a spec available?

Specifically how is 'locale_support: langpack' going to be used? Should the catalog describe which langpacks to install or is that going to be left to decide by subiquity calling the language support command?

Also do we really need a list of preinstalled languages, at the time we pull in language packs on the target it should be clear what is already available there?
-- 
https://code.launchpad.net/~mwhudson/livecd-rootfs/+git/livecd-rootfs/+merge/408855
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~mwhudson/livecd-rootfs/+git/livecd-rootfs:language-support-in-catalogs into livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list