[Merge] ~seb128/livecd-rootfs:canary-snaps-env into livecd-rootfs:ubuntu/master
Sebastien Bacher
seb128 at ubuntu.com
Mon Nov 23 22:53:20 UTC 2020
Thanks for the review, I've pushed an updated version of the change that uses the recommended function for the snapd setup, using it earlier is problematic because it mounts /var/cache/apt over a tmpfs which fails the build on enospace to download the binaries required
the setup function also got changed to use realpath on the directory since that's what mounts is listing and otherwise it's not doing any unmounting
the previous change could probably be split in another commit or merge request if you prefer
--
https://code.launchpad.net/~seb128/livecd-rootfs/+git/livecd-rootfs/+merge/393981
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list