[Merge] ~seb128/livecd-rootfs:canary-snaps-env into livecd-rootfs:ubuntu/master

Dimitri John Ledkov dimitri.ledkov+lp at canonical.com
Thu Nov 19 17:33:29 UTC 2020


Review: Needs Fixing

Later, after 1ca11c97, we found out that doing recursive unmount breaks all the things.

Since recursive goes and unmounts more than it should.

Thus you can see that we then did 109e6c6613aae4cbd4e8793709ab52c3cbce214c which calls into setup_mountpoint / teardown_mountpoint.

teardown_mountpoint on the other hand interates /proc/self/mounts and only unmounts things that are under a mountpoint, and thus doesn't break the container/chroot/host where the build is happening.

Given that functions are available here, can we call setup_mountpoint / teardown_mountpoint around here? Instead of doing a few implementation of mounting /dev & /sys?

Note that setup_mountpoint does a lot more things to make snap seeding work correctly, by bindmounting uptodate apparmor & seccomp filesystems, as otherwise snap preseeding is generated for like bionic kernel; rather than something up to date.

-- 
https://code.launchpad.net/~seb128/livecd-rootfs/+git/livecd-rootfs/+merge/393981
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.



More information about the Ubuntu-reviews mailing list