[Merge] ~kondor-dani/compiz:dbus-fix into compiz:master

Alberts Muktupāvels alberts.muktupavels at gmail.com
Thu May 21 16:39:17 UTC 2020


I am looking at:
http://www.cplusplus.com/reference/list/list/erase/
http://www.cplusplus.com/reference/list/list/clear/

What exactly "which are destroyed" means? Sounds like it should be destroyed already!? Sorry, I don't know C++...

Check ~EventManager, it calls g_source_destroy for each fd. For consistently maybe g_source_destroy (w->gobj ()) is better?

Also did you see FIXME in CompWatchFd::internalCallback? Is that unrelated to your findings?
-- 
https://code.launchpad.net/~kondor-dani/compiz/+git/compiz/+merge/384366
Your team Compiz Maintainers is requested to review the proposed merge of ~kondor-dani/compiz:dbus-fix into compiz:master.



More information about the Ubuntu-reviews mailing list