[Merge] ~paelzer/ubuntu-seeds/+git/ubuntu:update-libvirt-seeding into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:focal

Robie Basak robie.basak at canonical.com
Wed Feb 5 10:18:41 UTC 2020


Review: Approve

Looks good.

2607839: looks good. I trust that you know what it transitioned to and have those listed correctly here.

a652321:

> build depends no more need to be in main

True, but a package can only use a build dependency in universe if certain conditions are met (I'd have to look it up, but broadly that apart from the build nothing from universe ends up being used in a main-only system).

Are you sure that nothing in main that uses libvirt-dev as a build dependency will be caused to break these conditions with this demotion? Sorry if you've already checked this but I think it needs to be documented that you did.

Once checked, +1.
-- 
https://code.launchpad.net/~paelzer/ubuntu-seeds/+git/ubuntu/+merge/378575
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:focal.



More information about the Ubuntu-reviews mailing list