[Merge] ~davidkrauser/livecd-rootfs/+git/livecd-rootfs:hyperv-gallery-images into livecd-rootfs:ubuntu/master

Ken VanDine ken.vandine at canonical.com
Wed May 8 21:26:26 UTC 2019


> First, thanks for taking on this effort to upstream this code. In addition the
> inline comments, I have a general comment about the use of "ubuntu:desktop-
> preinstalled" for the project:subproject. I do not know if there are other
> implications of using the ubuntu project, but it seams way too generic for
> this. The more I think about this, I think the project should be "ubuntu-
> desktop-preinstalled" or similar with no subproject.
> 

I used the "ubuntu" project here as it already existed for ubuntu-desktop.  In fact, the "ubuntu" project is ubuntu-desktop.  It just didn't have a subdir as it didn't use any hooks.  The hook won't do anything when run without the SUBPROJECT of desktop-preinsalled.  If we wanted to use a different project, we'd need to make further changes to make sure it did everything the ubuntu project does.
-- 
https://code.launchpad.net/~davidkrauser/livecd-rootfs/+git/livecd-rootfs/+merge/366849
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.



More information about the Ubuntu-reviews mailing list