[Merge] ~davidkrauser/livecd-rootfs/+git/livecd-rootfs:hyperv-gallery-images into livecd-rootfs:ubuntu/master
Francis Ginther
francis.ginther at canonical.com
Wed May 8 02:24:34 UTC 2019
Review: Needs Fixing
First, thanks for taking on this effort to upstream this code. In addition the inline comments, I have a general comment about the use of "ubuntu:desktop-preinstalled" for the project:subproject. I do not know if there are other implications of using the ubuntu project, but it seams way too generic for this. The more I think about this, I think the project should be "ubuntu-desktop-preinstalled" or similar with no subproject.
I also need to look more closely at the divert/undivert-grub functions and where they are used. Ultimately I think this code should be identical to the ubuntu-cpc images as I don't think we're doing anything special here.
Marking needs fixing as some of my comments from before need addressing.
--
https://code.launchpad.net/~davidkrauser/livecd-rootfs/+git/livecd-rootfs/+merge/366849
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list