[Merge] ~mvo/livecd-rootfs:snap-validate-seed into livecd-rootfs:ubuntu/master

Robert C Jennings robert.jennings at canonical.com
Mon Jul 15 17:31:21 UTC 2019


Binary hooks that add pre-seeded snaps also need to add a call to 'snap debug validate-seed' and we risk missing this addition to new and existing ones.  This was the reason I requested the check in snap_preseed() rather than in preinstall_snaps().  It would cause the validation to run as each snap is added, but I would prefer, that if it works well enough, to missing call sites when someone adds a snap_preseed() and doesn't know to also add a new 'snap debug validate-seed' call.
-- 
https://code.launchpad.net/~mvo/livecd-rootfs/+git/livecd-rootfs/+merge/370065
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.



More information about the Ubuntu-reviews mailing list