[Merge] ~mvo/livecd-rootfs:snap-validate-seed into livecd-rootfs:ubuntu/master
Iain Lane
iain at orangesquash.org.uk
Mon Jul 15 16:51:49 UTC 2019
I don't think that's where rcj suggested - that was "snap_preseed", and this is "preinstall_snaps" which is just one place where snaps are preseeded.
But I actually think it's nice that you call it after all the snaps are supposed to have been added - so how about leaving the call where you have it now and additionally adding it to lb_chroot_layered (at the end of lb_chroot_install_snaps) and 032-installer-squashfs.binary? Adding to snap_preseed will AFAICS repeatedly validate for each seeded snap and I'm not sure it's guaranteed (or we care) if the intermediate states are themselves valid, just the end product.
What do you both think? Is that sensible?
--
https://code.launchpad.net/~mvo/livecd-rootfs/+git/livecd-rootfs/+merge/370065
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list