[Merge] lp:~mterry/webbrowser-app/less-ubuntucolors into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon May 23 10:38:18 UTC 2016
Those changes look good, thanks Michael for taking some time to apply them. A couple of minor comments:
The OK button in src/app/ConfirmDialog.qml should have an explicit color of theme.palette.normal.positive, for consistency. And probably src/app/AlertDialog.qml too.
Not sure what should be done with src/app/BeforeUnloadDialog.qml.
In the history and bookmarks views (wide layout), the color of the current date/folder in the left column when it doesn’t have active focus should be 'selected.backgroundText' instead of 'normal.positionText', according to https://docs.google.com/presentation/d/1Sgf536u5LgKgl41x7xeEeo-XibEEPQZ_phugEArwvec/edit?ts=5728be0d#slide=id.g12f5d7958f_0_92 (that visual design update hasn’t been implemented yet, I’ll get to it soon, but since you’re changing some colors now, I reckon it would be better to use the updated ones now).
Could you please update the dates in the copyright headers for files that were changed?
--
https://code.launchpad.net/~mterry/webbrowser-app/less-ubuntucolors/+merge/295412
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/webbrowser-app/less-ubuntucolors into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list