[Merge] lp:~mterry/webbrowser-app/less-ubuntucolors into lp:webbrowser-app

Michael Terry michael.terry at canonical.com
Mon May 23 03:17:53 UTC 2016


The proposal to merge lp:~mterry/webbrowser-app/less-ubuntucolors into lp:webbrowser-app has been updated.

Description changed to:

There are still a lot of UbuntuColor.darkGrey instances sitting out there (which is now more properly called UbuntuColors.slate, or backgroundSecondaryText in the normal theme).  And a lot of hardcoded "#xxxxxx"!  But I didn't deal with all of it, since I'm not super familiar with the code base.

And I left the "this page is bookmarked" icon fill color as UbuntuColors.orange.  That was a unique-enough case that I wasn't sure what would be appropriate there.

For more details, see:
https://code.launchpad.net/~mterry/webbrowser-app/less-ubuntucolors/+merge/295412
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/webbrowser-app/less-ubuntucolors into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list