[Merge] lp:~abreu-alexandre/webbrowser-app/front-camera-as-default-capture into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Jun 16 17:27:15 UTC 2016
As a consequence of the above remark, the "Prefix" part of 'cameraNamePrefixVideoCaptureDefault' should be removed, seeing that it’s not a prefix any longer.
For consistency with the rest of the codebase, can you please rename "__internal" to "internal" (without the leading underscores) ?
Can 'currentWebviewContext' be renamed 'currentWebcontext'?
Is the 'defaultVideoCaptureMediaIdUpdated' signal really needed? Can we not connect to currentWebviewContext.onDefaultVideoCaptureDeviceIdChanged instead?
The added 'browserView' id seems to be unused. Can it be removed?
--
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/front-camera-as-default-capture/+merge/291527
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list