[Merge] lp:~abreu-alexandre/webbrowser-app/front-camera-as-default-capture into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Jun 16 17:10:33 UTC 2016
Review: Needs Fixing
I just realized that i18n.dtr("oxide-qt", "Front") as a prefix won’t work (because gettext matches only exact strings, not prefixes), you need the exact i18n’d string exposed by oxide: "Front camera" (see https://git.launchpad.net/oxide/tree/shared/browser/media/oxide_video_capture_device_factory_linux.cc#n53). A comment to specify that this should remain in sync with oxide’s source code would be useful I think.
--
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/front-camera-as-default-capture/+merge/291527
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list