[Merge] lp:~dandrader/qtubuntu/betterSessionName into lp:qtubuntu
Gerry Boland
gerry.boland at canonical.com
Wed Jun 1 15:01:56 UTC 2016
Review: Needs Fixing
+for (int i = 0; i < args.count(); ++i) {
+ QString arg = args[i];
We have Q_FOREACH
Do you really need to read the FileInfo object? Why not just drop the ".qml" from the file name?
+ u_application_id_new_from_stringn(sessionName.data(), sessionName.count());
Does the api expect sessionName to always exist, or will it make a copy itself?
--
https://code.launchpad.net/~dandrader/qtubuntu/betterSessionName/+merge/296198
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.
More information about the Ubuntu-reviews
mailing list