[Merge] lp:~phablet-team/mir/track-plug-state into lp:mir

[Alfonso Sanchez-Beato]

On Fri, Feb 12, 2016 at 3:01 PM, Alan Griffiths <alan at octopull.co.uk> wrote:

> Review: Needs Fixing
>
> + if (is_plugged[mga::as_hwc_display(display_name)].load() == false)
>
> Can be written
>
>   if (!is_plugged[mga::as_hwc_display(display_name)])
>
> ~~~~
>
> +    is_plugged[HWC_DISPLAY_PRIMARY].store(true);
> +    is_plugged[HWC_DISPLAY_EXTERNAL].store(false);
> + is_plugged[HWC_DISPLAY_VIRTUAL].store(true);
>
> Constructors should use initialization, not assignment
>

The copy constructor is =deleted for atomic types apparently, so I could
not initialize directly.


> --
> https://code.launchpad.net/~phablet-team/mir/track-plug-state/+merge/285854
> Your team Ubuntu Phablet Team is subscribed to branch
> lp:~phablet-team/mir/track-plug-state.
>

-- 
https://code.launchpad.net/~phablet-team/mir/track-plug-state/+merge/285854
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/mir/track-plug-state.