[Merge] lp:~phablet-team/mir/track-plug-state into lp:mir
Alan Griffiths
alan at octopull.co.uk
Fri Feb 12 14:01:36 UTC 2016
Review: Needs Fixing
+ if (is_plugged[mga::as_hwc_display(display_name)].load() == false)
Can be written
if (!is_plugged[mga::as_hwc_display(display_name)])
~~~~
+ is_plugged[HWC_DISPLAY_PRIMARY].store(true);
+ is_plugged[HWC_DISPLAY_EXTERNAL].store(false);
+ is_plugged[HWC_DISPLAY_VIRTUAL].store(true);
Constructors should use initialization, not assignment
--
https://code.launchpad.net/~phablet-team/mir/track-plug-state/+merge/285854
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/mir/track-plug-state.
More information about the Ubuntu-reviews
mailing list