[Merge] lp:~sil2100/livecd-rootfs/pocket-desktop into lp:livecd-rootfs

Łukasz Zemczak lukasz.zemczak at canonical.com
Fri Sep 18 08:41:35 UTC 2015


The proposal to merge lp:~sil2100/livecd-rootfs/pocket-desktop into lp:livecd-rootfs has been updated.

Description changed to:

Add support for pocket-desktop. We do this through SUBPROJECT right now as adding a new project would require modifying multiple lines and copy-pasting the whole hook list - which is complete boilerplate and makes maintenance troublesome, as any change to ubuntu-touch hooks would have to be duplicated in ubuntu-pd (symlinks don't work).

Steve said he would prefer to have it as a separate project, and I can surely make it a separate project, but... It would pain me very much to add so much unnecessary changes for something that can be done with a 3 line diff with SUBPROJECT. I leave it up to the reviewers.

Another reason to keep it as a subproject: if we add a new project, we need to modify cdimage code. Subprojects do not require any real changes.

For more details, see:
https://code.launchpad.net/~sil2100/livecd-rootfs/pocket-desktop/+merge/271448
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/livecd-rootfs/pocket-desktop into lp:livecd-rootfs.



More information about the Ubuntu-reviews mailing list