[Merge] lp:~sil2100/livecd-rootfs/pocket-desktop into lp:livecd-rootfs
Łukasz Zemczak
lukasz.zemczak at canonical.com
Fri Sep 18 08:40:39 UTC 2015
Łukasz Zemczak has proposed merging lp:~sil2100/livecd-rootfs/pocket-desktop into lp:livecd-rootfs.
Commit message:
Add support for pocket-desktop. We do this through SUBPROJECT right now as adding a new project would require modifying multiple lines and copy-pasting the whole hook list (or symlinking, if that works) - which is complete boilerplate and makes maintenance troublesome.
Requested reviews:
Ubuntu Core Development Team (ubuntu-core-dev)
For more details, see:
https://code.launchpad.net/~sil2100/livecd-rootfs/pocket-desktop/+merge/271448
Add support for pocket-desktop. We do this through SUBPROJECT right now as adding a new project would require modifying multiple lines and copy-pasting the whole hook list (or symlinking, if that works) - which is complete boilerplate and makes maintenance troublesome.
Steve said he would prefer to have it as a separate project, and I can surely make it a separate project, but... It would pain me very much to add so much unnecessary changes for something that can be done with a 3 line diff with SUBPROJECT. I leave it up to the reviewers.
--
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/livecd-rootfs/pocket-desktop into lp:livecd-rootfs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 374 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150918/1f55eb09/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list