[Merge] lp:~nick-dedekind/qtubuntu/lp1475678.surface-occlude into lp:qtubuntu

Nick Dedekind nick.dedekind at canonical.com
Mon Oct 12 13:19:16 UTC 2015


> In src/ubuntumirclient/window.cpp:
> 
> """
> +    window()->setVisible(exposed);
> """
> 
> You sure this is necessary?
> 
> It doesn't look right that a backend is calling the client-side API. Since,
> QWindow::visible property is under control of application code, it would be
> weird that it suddenly turn false without app code having explicitly set it
> (either via setVisible(false) or hide()).

Apparently not. Looks like it's the isExposed that stops the redraw.
I've fixed it up now.
-- 
https://code.launchpad.net/~nick-dedekind/qtubuntu/lp1475678.surface-occlude/+merge/273424
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list