[Merge] lp:~nick-dedekind/qtubuntu/lp1475678.surface-occlude into lp:qtubuntu

Daniel d'Andrada daniel.dandrada at canonical.com
Wed Oct 7 14:19:05 UTC 2015


Review: Needs Information

In src/ubuntumirclient/window.cpp:

"""
+    window()->setVisible(exposed);
"""

You sure this is necessary?

It doesn't look right that a backend is calling the client-side API. Since, QWindow::visible property is under control of application code, it would be weird that it suddenly turn false without app code having explicitly set it (either via setVisible(false) or hide()).
-- 
https://code.launchpad.net/~nick-dedekind/qtubuntu/lp1475678.surface-occlude/+merge/273424
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list