[Merge] lp:~uriboni/webbrowser-app/ctrl-click-link into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Nov 10 11:52:21 UTC 2015


Review: Needs Fixing

Something weird is happening with this branch. The following unit test is consistently failing in silo builds (xenial armhf):

FAIL! : QmlTests::BrowserTab::test_load_unload() property webviewPresent
   Actual (): false
   Expected (): true
   Loc: [/«BUILDDIR»/webbrowser-app-0.23+16.04.20151109.1/tests/unittests/qml/tst_BrowserTab.qml(81)]

See e.g. a full build log here: https://launchpadlibrarian.net/225643181/buildlog_ubuntu-xenial-armhf.webbrowser-app_0.23%2B16.04.20151109.1-0ubuntu1_BUILDING.txt.gz.

The same test passes on other architectures (amd64, i386), and also on vivid armhf.

I’ve ruled out other branches, it seems the regression is indeed introduced by the changes in this branch.

We need to figure that one out.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/ctrl-click-link/+merge/276640
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list