[Merge] lp:~uriboni/webbrowser-app/qml-tabs-model into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Sun Nov 8 23:11:11 UTC 2015


> webbrowser_app.tests.test_tabs.TestTabsFocus.test_focus_on_close is broken on
> desktop

It is really odd that this was working on jenkins, but not when we run it on our machines.
Fixed in any case
 
> > And in test_shouldNotInsertTabAtInvalidIndex, you should also verify
> > that currentIndex and currentTab remain unchanged.
> 
> This hasn’t been done.
 
Fixed
 
> 846     +            // verify that when the model is not empty -1 is not a valid
> 847     +            // current index anymore
> 
> s/anymore// : -1 never was a valid value for currentIndex, at least not in the
> current implementation in trunk

I mean that -1 stops being a valid index when the model is not empty. But removed "anymore" to avoid confusion anyway.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/qml-tabs-model/+merge/270408
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list