[Merge] lp:~uriboni/webbrowser-app/qml-tabs-model into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri Nov 6 10:36:50 UTC 2015


Review: Needs Fixing

webbrowser_app.tests.test_tabs.TestTabsFocus.test_focus_on_close is broken on desktop


> And in test_shouldNotInsertTabAtInvalidIndex, you should also verify
> that currentIndex and currentTab remain unchanged.

This hasn’t been done.


846	+            // verify that when the model is not empty -1 is not a valid
847	+            // current index anymore

s/anymore// : -1 never was a valid value for currentIndex, at least not in the current implementation in trunk

-- 
https://code.launchpad.net/~uriboni/webbrowser-app/qml-tabs-model/+merge/270408
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list