[Merge] lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app
Arthur Mello
arthur.mello at canonical.com
Wed Jul 29 01:01:22 UTC 2015
> - In the design spec, there is no "All days" section. While I agree that it’s
> an interesting addition, have you discussed it with the design team?
No, that was not discussed with design team yet.
> - Having sections in the right panel makes sense for "all days", but it
> doesn’t for all the other entries, that cover only one single day (and the
> design spec doesn’t have them either)
Fixed
> - Timestamp formatting for history entries in the right panel isn’t correct
> on my desktop (localized in French, it should show timestamps in the 24h
> format, but they are shown in the 12h format with the AM/PM indicator)
That was requested by Bill to be in the 12h format, maybe I am missing some internationalization time format for US users? I reverted to be displayed in the 24h since that is how it is in the design spec
> - In the design spec, the selection highlight for the right panel doesn’t
> cover the timestamp (see https://docs.google.com/presentation/d/1P6A7ZsI03sPfu
> I9vzPeC0VcUfIgugxnU4QyObH6UNTs/edit#slide=id.g75d5dd944_077)
WIP. Should the "delete" leading action cover the timestamp or not? I didnt find any definition about it in the design spec.
> - In the design spec, the selected day in the left panel is coloured orange
Fixed
> - After I delete some entries from the multi-selection view, keyboard
> navigation is broken (including pressing ESC to close the view). It starts
> working again after I click on an entry in the left panel.
WIP
> - Deleting one single entry with a swipe-to-the-right gesture displays the
> "delete" leading action all over the left panel.
Fixed
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-history_view_convergence/+merge/263052
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list