[Merge] lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Tue Jul 28 15:00:51 UTC 2015
Review: Needs Fixing
Some functional and visual issues, in no particular order (code review will follow):
- In the design spec, there is no "All days" section. While I agree that it’s an interesting addition, have you discussed it with the design team?
- Having sections in the right panel makes sense for "all days", but it doesn’t for all the other entries, that cover only one single day (and the design spec doesn’t have them either)
- Timestamp formatting for history entries in the right panel isn’t correct on my desktop (localized in French, it should show timestamps in the 24h format, but they are shown in the 12h format with the AM/PM indicator)
- In the design spec, the selection highlight for the right panel doesn’t cover the timestamp (see https://docs.google.com/presentation/d/1P6A7ZsI03sPfuI9vzPeC0VcUfIgugxnU4QyObH6UNTs/edit#slide=id.g75d5dd944_077)
- In the design spec, the selected day in the left panel is coloured orange
- After I delete some entries from the multi-selection view, keyboard navigation is broken (including pressing ESC to close the view). It starts working again after I click on an entry in the left panel.
- Deleting one single entry with a swipe-to-the-right gesture displays the "delete" leading action all over the left panel.
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-history_view_convergence/+merge/263052
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list