[Merge] lp:~renatofilho/buteo-sync-plugins-contacts/new-code into lp:buteo-sync-plugins-contacts

[Renato Araujo Oliveira Filho]

> Line 7321
> +    // Include "X-HTTP-Method-Override: DELETE" in the delete POST method to
> avoid blocking of HTTP DELETE message by firewalls
> +    //const void DELETE( const QString contactId );
> 
> Should this still be here (currently commented out)?
Fixed rev. 40

> 
> I think you need to add Canonical and yourself to google/LICENSE
Fixed rev. 41

> 
> 
> Line 8099,
> +    /*! \brief constructor
> +     */
> +    ~ContactsChangeNotifier();
> 
> constructor -> destructor
Fixed rev. 42
> 
> 
> google/Makefile is currently in version control, presumably this can be
> removed as it's a generated file?
Fixed rev. 43

> 
> 
> tests/unittest/CMakeLists.txt appears to have DOS line endings (just a quick
> run through dos2unix will fix this)
Fixed rev. 44

> 
> 
> Line 11156
> +        // remote source will be initialized after sucess
> sucess -> success
> 
> 
> Line 11187
> +        QTest::newRow("page division exaclty")          << 5
> exaclty -> exactly
> 
> 
> Line 11258
> +        // trasaction commit will be fired once with empty list
> trasaction -> transaction
> 
> 
> Line 11751
> +        // chek if avatar still the same
> chek -> check
> 
> 
> Line 11843
> +        // check if the repported error is correct
> repported -> reported
> 
> 
> Line 11923
> +        // check each contat details
> contat -> contact
> 
> 
> Line 12769
> +        // Anniversay
> Anniversay -> Anniversary
> 
> 
> All the test VCF files except for
> tests/unittest/data/slow_sync_with_pages_remote.vcf have DOS style line
> endings.
The default EOL for vcards is the DOS format.

> 
> Is there any package that supplies QContactMemoryBackend in a way that could
> be linked against to remove the need to including the source for it as part of
> this package?
Yes QtPim package contains the memory backend. But I copied it to the porjects because I need some small changes necessary to help me to run my tests. And these changes does not make sens upstream they are very specific.

-- 
https://code.launchpad.net/~renatofilho/buteo-sync-plugins-contacts/new-code/+merge/264335
Your team Ubuntu Phablet Team is subscribed to branch lp:buteo-sync-plugins-contacts.