[Merge] lp:~renatofilho/buteo-sync-plugins-contacts/new-code into lp:buteo-sync-plugins-contacts
Michael Sheldon
michael.sheldon at canonical.com
Thu Jul 23 12:54:54 UTC 2015
This is the last batch of issues going all the way to the end of the diff, so once these have been addressed I'll do a quick check over the previous corrections and then we should be good to approve this from a general code review stand point.
Line 7321
+ // Include "X-HTTP-Method-Override: DELETE" in the delete POST method to avoid blocking of HTTP DELETE message by firewalls
+ //const void DELETE( const QString contactId );
Should this still be here (currently commented out)?
I think you need to add Canonical and yourself to google/LICENSE
Line 8099,
+ /*! \brief constructor
+ */
+ ~ContactsChangeNotifier();
constructor -> destructor
google/Makefile is currently in version control, presumably this can be removed as it's a generated file?
tests/unittest/CMakeLists.txt appears to have DOS line endings (just a quick run through dos2unix will fix this)
Line 11156
+ // remote source will be initialized after sucess
sucess -> success
Line 11187
+ QTest::newRow("page division exaclty") << 5
exaclty -> exactly
Line 11258
+ // trasaction commit will be fired once with empty list
trasaction -> transaction
Line 11751
+ // chek if avatar still the same
chek -> check
Line 11843
+ // check if the repported error is correct
repported -> reported
Line 11923
+ // check each contat details
contat -> contact
Line 12769
+ // Anniversay
Anniversay -> Anniversary
All the test VCF files except for tests/unittest/data/slow_sync_with_pages_remote.vcf have DOS style line endings.
Is there any package that supplies QContactMemoryBackend in a way that could be linked against to remove the need to including the source for it as part of this package?
--
https://code.launchpad.net/~renatofilho/buteo-sync-plugins-contacts/new-code/+merge/264335
Your team Ubuntu Phablet Team is subscribed to branch lp:buteo-sync-plugins-contacts.
More information about the Ubuntu-reviews
mailing list