[Merge] lp:~timchen119/ubuntu/utopic/bluez/lp1035431 into lp:ubuntu/bluez

[Tim Chen]

Tim Chen has proposed merging lp:~timchen119/ubuntu/utopic/bluez/lp1035431 into lp:ubuntu/bluez.

Requested reviews:
  Ubuntu Development Team (ubuntu-dev)
Related bugs:
  Bug #1035431 in bluez (Ubuntu): "bluetooh-wizard failed to connect to a keyboard(logitech)"
  https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/1035431

For more details, see:
https://code.launchpad.net/~timchen119/ubuntu/utopic/bluez/lp1035431/+merge/219626

This fixed the issue for the paring issue on Logitech K810 and HP bluetooth keyboard K4000 and should also fixed any ssp paired bluetooth keyboard.

The root problem here is that in bluez4, the doc (agent-api.txt), specific that the
function 

void DisplayPasskey(object device, uint32 passkey, uint8 entered)

however in bluez4's src/agent.c agent_display_passkey()
didn't pass the entered correct "enter" parameter,
and most of client implementation in linux (at least gnome-bluetooth, bluedevil, blueman) follows the specification in the api document so they never receive correct parameter.

This is already fixed in bluez5, 
however due to the compatibility issue between bluez4 and bluez5
this never being backported in bluez4.

Another related merge is at https://code.launchpad.net/~timchen119/ubuntu/utopic/gnome-bluetooth/lp1035431

gnome-bluetooth do follow the doc and, but still have issues when display the number,
the number will not correctly display in current implementation,
however gnome-bluetooth is being removed in recent gnome upstream, so we need to maintain a ubuntu distro patch here.

This request is from our OEM so please help to review these patch and see if there's things I can improve this patch. If the patch is accepted I'll send SRUs to trusty (OEM shipping image is LTS based, so it will be trusty right now).
-- 
https://code.launchpad.net/~timchen119/ubuntu/utopic/bluez/lp1035431/+merge/219626
Your team Ubuntu branches is subscribed to branch lp:ubuntu/bluez.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 397747 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140515/0f1c5429/attachment-0003.diff>