[Merge] lp:~jani/goget-ubuntu-touch/runscript into lp:goget-ubuntu-touch

Sergio Schvezov sergio.schvezov at canonical.com
Wed May 14 10:36:18 UTC 2014


Review: Needs Fixing

34	+ if fi.Mode()&0100 == 0 {
35	+ log.Fatalf("%s not executable", script)
36	+ }

Can't we make this executable if it isn't, as a copy perhaps to not modify the original?

46	+ adb.RebootRecovery()

Can this be common? If I start the process from a booted system I get:
2014/05/14 07:32:52 Preparing to run ../sh.sh to finish the flashing process
/bin/bash: system-image-upgrader: command not found

Or if you want this to only run just add a prestart condition of if cmd.RunScript != "" && !cmd.Bootstrap

I prefer the former, but I don't know if this is something you already had thoughts on.
-- 
https://code.launchpad.net/~jani/goget-ubuntu-touch/runscript/+merge/219313
Your team Ubuntu Phablet Team is subscribed to branch lp:goget-ubuntu-touch.



More information about the Ubuntu-reviews mailing list