[Merge] lp:~israeldahl/ubuntu/utopic/lmms/lmms_1.0.1 into lp:ubuntu/lmms

Timo Jyrinki timo.jyrinki at canonical.com
Fri May 9 06:18:17 UTC 2014


Review: Needs Fixing

Hi, thanks for your work again on the lmms!

One thing that needs fixing: the version should be 1.0.1-0ubuntu1. Since the upstream version is not "1.0.1-src", but just "1.0.1" in practice (what it's called) even though the downloadable tarball has "-src" in its name.

But otherwise it's very nice upstream did a 1.0.1 release, and your branch has it imported correctly (the auto-generated orig tarball is bit-for-bit identical to upstream's downloadable file) and the only changes is the debian/ dir.

Additionally I think you should simply bzr rm debian/patches since nothing is used from there.

And finally I think the changelog entry could be more verbose. For example instead of just "* New upstream release." you could have:
* New upstream release.
  - Stable branch release to fix problems with the earlier master branch snapshot.

Again, thanks! It looks clean and good now aside from the above remarks.
-- 
https://code.launchpad.net/~israeldahl/ubuntu/utopic/lmms/lmms_1.0.1/+merge/217857
Your team Ubuntu branches is requested to review the proposed merge of lp:~israeldahl/ubuntu/utopic/lmms/lmms_1.0.1 into lp:ubuntu/lmms.



More information about the Ubuntu-reviews mailing list