[Merge] lp:~artmello/webbrowser-app/webbrowser-app-new_history into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Jul 17 11:55:34 UTC 2014
A few additional comments:
> 1) many sites are missing favicons, especially the ones in the history from
> some days ago. I believe Olivier said these are not stored locally, but maybe
> they should be. At minimum we should have a place holder icon (like a globe or
> something) for the sites that don't have favicons. Would be better than blank
> white shape.
The lack of a persistent cache for favicons is tracked by bug #1340585, but let’s address it separately.
We could use a placeholder icon indeed. I’ve been using one in my new-header branch, in fact we could probably modify the Favicon component to show a fallback icon when not available (see what I did at http://bazaar.launchpad.net/~osomon/webbrowser-app/new-header/view/head:/src/app/webbrowser/AddressBar.qml#L60).
> 3) The second level list (when expanding the main list) is scrollable, but
> don't know if it needs to be as we're only showing two items
I think it shouldn’t be scrollable.
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-new_history/+merge/226871
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/webbrowser-app/webbrowser-app-new_history into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list