[Merge] lp:~sdeziel/ubuntu/precise/xl2tpd/fix-for-lp1244780 into lp:ubuntu/precise/xl2tpd

[Simon Déziel]

Thanks for the review!

> Thanks for the patch. Some notes:
>  * avp-fix-lenght-size.diff has the correct DEP3 Origin, but the description
> does not match the upstream commit. Also, the patch name has a typo
> (s/lenght/length/)

Sure, I'll fix this.

>  * a later upstream commit seems to also be needed: https://github.com/xeleran
> ce/xl2tpd/commit/7c2e4a8651307896e7546d8652804b39cf514b4a

This commit was later reverted by myself (https://github.com/xelerance/xl2tpd/commit/8007acfcc3bc543067fd6b5a7209d81ad47db05e) and the proper fix to those AVP headers is
really: https://github.com/xelerance/xl2tpd/commit/5619e1771048e74b729804e8602f409af0f3faea

>  * avp-nonmandatory-fix.diff should have: Bug-Debian: http://bugs.debian.org
> /cgi-bin/bugreport.cgi?bug=680146

Will add it.

>  * The version of xl2tpd in precise is also in quantal-saucy. I think leaving
> quantal and raring alone is fine, but an update for saucy would be nice. As
> such, can you adjust the version to be 1.3.1+dfsg-1ubuntu0.12.04.1 and 1.3.1
> +dfsg-1ubuntu0.13.10.1 for precise and saucy respectively?

Makes sense.

> TBH, it is very hard to follow what is actually needed to fix this issue.

The interop issue with both Checkpoint and Android are corrected by:

1) disabling the UDP checksums (useless since over IPsec)
2) fixing the size of the length param for AVP headers
3) marking some AVP headers as non-mandatory

> Upstream only had one 'issue': https://github.com/xelerance/xl2tpd/pull/31,
> yet other seemingly unrelated patches keep flowing in to this MP and upstream
> trunk. Can you fix up the patches as requested, then explain what is needed
> and why so the next reviewer can have an easier time looking at this?

I'll follow all your recommendation and resubmit, thanks again.

-- 
https://code.launchpad.net/~sdeziel/ubuntu/precise/xl2tpd/fix-for-lp1244780/+merge/194247
Your team Ubuntu branches is subscribed to branch lp:ubuntu/precise/xl2tpd.