[Merge] lp:~sdeziel/ubuntu/precise/xl2tpd/fix-for-lp1244780 into lp:ubuntu/precise/xl2tpd

[Jamie Strandboge]

Review: Needs Fixing

Thanks for the patch. Some notes:
 * avp-fix-lenght-size.diff has the correct DEP3 Origin, but the description does not match the upstream commit. Also, the patch name has a typo (s/lenght/length/)
 * a later upstream commit seems to also be needed: https://github.com/xelerance/xl2tpd/commit/7c2e4a8651307896e7546d8652804b39cf514b4a
 * avp-nonmandatory-fix.diff should have: Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680146
 * The version of xl2tpd in precise is also in quantal-saucy. I think leaving quantal and raring alone is fine, but an update for saucy would be nice. As such, can you adjust the version to be 1.3.1+dfsg-1ubuntu0.12.04.1 and 1.3.1+dfsg-1ubuntu0.13.10.1 for precise and saucy respectively?

TBH, it is very hard to follow what is actually needed to fix this issue. Upstream only had one 'issue': https://github.com/xelerance/xl2tpd/pull/31, yet other seemingly unrelated patches keep flowing in to this MP and upstream trunk. Can you fix up the patches as requested, then explain what is needed and why so the next reviewer can have an easier time looking at this?

Thanks!
-- 
https://code.launchpad.net/~sdeziel/ubuntu/precise/xl2tpd/fix-for-lp1244780/+merge/194247
Your team Ubuntu branches is subscribed to branch lp:ubuntu/precise/xl2tpd.