[Merge] lp:~smoser/ubuntu-dev-tools/better-proxy-support into lp:ubuntu-dev-tools

Scott Moser smoser at canonical.com
Tue Oct 25 23:29:23 UTC 2011


I would personally find '[ -n "$var" ]' more readable than '[ "${var-xx}" = "xx" ]'.

DEBOOTSTRAP_PROXY, I'm not going to insist on that, but it is consistent with the other variables naming that affect mk-sbuild.  There probably is something that needs to be done to actually make use of it though (right now it wont do anything).  I think its useful for consistency.

Why not nest the heredoc?  it works, its a single script... I dont find it easier one way or another.

I didn't mean to remove the cleanup of finish.sh, I had that done for debugging.

  
-- 
https://code.launchpad.net/~smoser/ubuntu-dev-tools/better-proxy-support/+merge/80386
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~smoser/ubuntu-dev-tools/better-proxy-support into lp:ubuntu-dev-tools.



More information about the Ubuntu-reviews mailing list