[Merge] lp:~smoser/ubuntu-dev-tools/better-proxy-support into lp:ubuntu-dev-tools

Stefano Rivera launchpad at rivera.za.net
Tue Oct 25 21:19:23 UTC 2011


Re empty vars:
I meant things like -n "$var" rather than "${var--xx}" = "xx"

That still doesn't answer my question about the need for DEBOOTSTRAP_PROXY.

Why nest the heredoc in the heredoc? We create other scripts inside the chroot, outside finish.sh

Why remove the cleanup of finish.sh?
-- 
https://code.launchpad.net/~smoser/ubuntu-dev-tools/better-proxy-support/+merge/80386
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~smoser/ubuntu-dev-tools/better-proxy-support into lp:ubuntu-dev-tools.



More information about the Ubuntu-reviews mailing list