[Merge] lp:~stefanor/ubuntu-dev-tools/syncpackage-blacklist into lp:ubuntu-dev-tools

Stefano Rivera launchpad at rivera.za.net
Wed Aug 24 17:46:23 UTC 2011


> Could you preserve the way that debian_mirror was passed as None in the
> API-copy case?  That was IMO useful because there's no point scanning
> the Debian mirror in that case if a package version isn't on LP - it
> won't be able to copy it anyway.

I don't think that's a problem, no scanning ever takes place (just
directed poking), and we never get anything besides the dsc, which will
just be pulled from LP (provided it exists).

DebianSourcePackage has a built-in master mirror, anyway. These are just
optional extra mirrors.

/me gets the feeling ubuntutools.archive needs an LP-only mode

> > +    blacklisted = is_blacklisted(src_pkg.source)
> > +    if blacklisted:
> > +        Logger.error("Source package is blacklisted")
> > +        if isinstance(blacklisted, basestring):
> > +            Logger.error(u"Reason: %s", blacklisted)
> 
> It might be worth explaining to people what they can do about it if they
> think it's wrong (i.e. bug with an explanation, subscribe
> ~ubuntu-archive).

Good point.

-- 
https://code.launchpad.net/~stefanor/ubuntu-dev-tools/syncpackage-blacklist/+merge/72713
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~stefanor/ubuntu-dev-tools/syncpackage-blacklist into lp:ubuntu-dev-tools.



More information about the Ubuntu-reviews mailing list