[Bug 2084460] Re: [SRU] Please enable frame-pointer on Noble

[Mate Kukri]

nspr in noble is a build1 of the Debian package. The only delta between
noble and oracular are the frame pointer changes, this patch is a
backport of the oracular changes as  nspr - `2:4.35-1.1ubuntu1~24.04`.

Please see my dev PPA for a test build:
https://launchpad.net/~mkukri/+archive/ubuntu/dev/+packages

** Description changed:

  [ Impact ]
  
  In order to help developers with profiling, Ubuntu enabled frame-
  pointers for packages in the main archive.
  
  https://ubuntu.com/blog/ubuntu-performance-engineering-with-frame-
  pointers-by-default
  
  The `Affects` packages were missed due to the packaging issues. These
  have been fixed on Oracular and can now be ported to Noble.
  
  [ Test Plan ]
  
  Look at the DW_AT_producer in the associated debug ELF file for flags.
  -fno-omit-frame-pointer should be present after the fix.
  
  The following scripts can be used as a reference
  https://gist.github.com/julian-klode/85e55553f85c410a1b856a93dce77208
  https://gist.github.com/julian-klode/95818246eaef0ac6a54588f7f368e25c
  
+ The nspr package comes with a build time test-suite that should ensure
+ some level of functionality from the re-built library.
+ 
+ 	override_dh_auto_test:
+ 	ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
+ 	        $(MAKE) -C nspr/pr/tests
+ 	        $(MAKE) -C nspr/lib/tests
+ 	        # Skip gethost because it needs DNS, and thus networking.
+ 	        # Skip fdcach, peek and vercheck because they fail.
+ 	        # Skip socket because it freezes.
+ 	        # Skip getproto because it fails on some buildds.
+ 	        # Skip nblayer because it freezes on armel.
+ 	        cd nspr/pr/tests && grep -v 	'^\(fdcach\|gethost\|getproto\|nblayer\|peek\|socket\|vercheck\)$$' ./runtests.sh | 	sh - $(CURDIR)/nspr/dist
+ 	        cd nspr/lib/tests && LD_LIBRARY_PATH=$(CURDIR)/nspr/dist/bin$(addprefix 	:,$(LD_LIBRARY_PATH)) ./base64t
+ 	        cd nspr/lib/tests && LD_LIBRARY_PATH=$(CURDIR)/nspr/dist/bin$(addprefix 	:,$(LD_LIBRARY_PATH)) ./string
+ 	endif
+ 
+ 
  [ Where problems could occur ]
  
  No source changes are made. The packaging fixes have enabled other
  security hardening flags. This could have unintended effects.
  
  [ Other Info ]
  
  changes in dpkg have been made to make sure frame-pointers are not
  enabled on s390x and ppc64el.
  
  Bug reference with similar SRU -
  https://bugs.launchpad.net/ubuntu/+source/authbind/+bug/2081707

** Patch added: "nspr_4.35-1.1ubuntu1~24.04.diff"
   https://bugs.launchpad.net/ubuntu/+source/nspr/+bug/2084460/+attachment/5828201/+files/nspr_4.35-1.1ubuntu1~24.04.diff

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to nspr in Ubuntu.
https://bugs.launchpad.net/bugs/2084460

Title:
  [SRU] Please enable frame-pointer on Noble

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nspr/+bug/2084460/+subscriptions