[Bug 241937]

Jaws 241937 at bugs.launchpad.net
Sun Feb 10 11:55:10 UTC 2019


Comment on attachment 8902388
Bug 450915 - Increase the drag space of the TabsToolbar by 15px on the bottom to improve the tab reordering experience.

https://reviewboard.mozilla.org/r/173956/#review182352

::: browser/base/content/browser.css:184
(Diff revision 2)
>  .tabbrowser-tabs[movingtab] > .tabbrowser-tab[fadein]:not([selected]) {
>    transition: transform 200ms var(--animation-easing-function);
>  }
>  
> +#TabsToolbar[movingtab] > .tabbrowser-tabs {
> +  padding-bottom: 20px;

The more we increase this the harder it is to tear off a tab without
making a large mouse movement. We're trying to balance ease of
reordering tabs and tearing off tabs.

Chrome looks to tear off at about 15 pixes from their tab bar, even
though their navbar measures about 35px tall.

Edge tears off around 8-10px, but their implementation treats reordering
and tearing off pretty much as one-in-the-same.

Doing this for the top and the menubar isn't as straightforward due to
the visibility of the menubar etc and didn't seem worth the extra
complexity for a "nice-to-have".

I'll lower our amount to be closer to Chrome since we don't have a
metric that says what is the *best* value here, and we don't want to
make tearing tabs off too much harder.

::: browser/themes/shared/tabs.inc.css:29
(Diff revision 2)
>  :root:-moz-lwtheme {
>    --tab-line-color: var(--lwt-accent-color);
>  }
>  
>  #tabbrowser-tabs,
> +#tabbrowser-tabs > .tabbrowser-arrowscrollbox,

This was answered in comment 14. Because of how -moz-box-align:stretch;
is applying the space, the tabs shrink in size from 33px to 29px (on
Windows default density) with the increased padding-bottom.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/241937

Title:
  Handle tabs like other gnome apps

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/241937/+subscriptions



More information about the Ubuntu-mozillateam-bugs mailing list