[Bug 41179]

Jhorak 41179 at bugs.launchpad.net
Thu Feb 14 12:43:03 UTC 2013


Created attachment 713868
Store Master Password by using libsecret to Gnome Keyring patch v2

Thanks Stef for feedback. I've fixed mentioned issues.
(In reply to Stef Walter from comment #84)
> @@ +808,5 @@
> > +
> > +  secret_password_lookup(MOZILLA_SECRET_SCHEMA, nullptr, on_lookup_finished, this,
> > +                         "application", MOZ_APP_NAME,
> > +                         "profile", profileName.get(),
> > +                         NULL);
> 
> Are you sure you need to do this as async? I don't understand all aspects of
> how SyncRunnableBase works, but if this is a separate thread, you could just
> use secret_password_lookup_sync().
> 
The secret_password_lookup is called on main thread, so we have to use async function to update gui.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is a bug assignee.
https://bugs.launchpad.net/bugs/41179

Title:
  Integrate with Gnome Keyring

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/41179/+subscriptions




More information about the Ubuntu-mozillateam-bugs mailing list