Bug#628481: debclean: please respect the option 'unapply-patches' in debian/source/local-options

Reinhard Tartler siretart at tauware.de
Sun Jul 10 15:44:15 UTC 2011


Hi fellow Ubuntu Developers,

Context:

I've uploaded a change to devscripts in oneiric that unapplies patches
in packages that specify the option 'unapply-patches' in
debian/source/local-options. I personally missed that feature for quite
some time now.

Naturally, I've forwarded that change to debian and got the following
response. If someone objects to the change I've implemented, please tell
so me and I'll revert it. Otherwise, I'll follow what change James will
implement in debian and replace my implementation with his in ubuntu.

Cheers,
Reinhard.

On Sun, Jul 10, 2011 at 17:22:17 (CEST), James Vega wrote:

> On Sun, May 29, 2011 at 02:15:08PM +0200, Reinhard Tartler wrote:
>> In source format 3.0, the option 'unapply-patches' (usually set in
>> debian/source/local-options) is used to indicate that patches are to be
>> unapplied after building the package. This is commongly used when the
>> package itself is maintained in a VCS that contains unpatched upstream
>> source and where you want to keep the tree unpatched even after a
>> package build.
>> 
>> Having 'debuild clean' and 'debclean' respecting this setting would
>> streamline the workflow with source format 1.0, where a 'debclean'
>> restores the source tree to a state that allows further VCS operations
>> such as investigating and committing changes easily.
>
> Adding 'dpkg-source --after-build'/'dpkg-source --before-build' calls to
> the dpkg-buildpackage emulation of debuild does make sense and I'll add
> that.
>
> Honoring unapply-patches from 'debuild clean' doesn't correspond to how
> debuild is intended to work when the standard targets are given.  In
> that case, it's just a thin wrapper around 'debian/rules <target>'.
> This is also how 'dpkg-buildpackage --target <target>' works.
>
> I'm also hesitant to add this behavior to debclean by default.  Adding
> an option to call 'dpkg-source --after-build' is a possibility, but
> doing it by default so that there's parity with 1.0 source packages
> isn't a good enough argument.  1.0 source package and 3.0 source
> packages are handled differently by dpkg's tools and the devscripts
> tools should follow their lead in that regard.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4



More information about the ubuntu-devel mailing list