[ubuntu/karmic] sreadahead 1.0-5 (Accepted)

[Scott James Remnant]

On Sat, 2009-10-10 at 19:13 +0100, Matt Zimmerman wrote:

> On Sat, Oct 10, 2009 at 06:10:44PM +0100, Scott James Remnant wrote:
> > On Sat, 2009-10-10 at 11:30 +0000, Ubuntu Installer wrote:
> > 
> > > sreadahead (1.0-5) karmic; urgency=low
> > > 
> > >   * Use off_t instead of int for the index used relative to statbuf.st_size
> > >     (which is off_t), to prevent an overflow on files >2GB (LP: #414597)
> > > 
> > > Date: Sat, 10 Oct 2009 12:19:26 +0100
> > > Changed-By: Matt Zimmerman <mdz at ubuntu.com>
> > > Maintainer: Scott James Remnant <scott at ubuntu.com>
> > > https://launchpad.net/ubuntu/karmic/+source/sreadahead/1.0-5
> > > 
> > Doesn't this result in the pack file format changing?  Did you take care
> > to migrate that, or at least forcibly remove it[0] so that the size
> > change doesn't result in reading random data after this upgrade.
> 
> I don't think it does; it's just a local variable.  There is probably
> another bug in there which would require changing the format, but I didn't
> go further, because this change got it working properly for me, and if I
> tried to fix all of the bugs I found it would have taken all day.
> 
Ah yes, you're probably right that there's another bug under there that
we'll find later.  But that's later ;-)

I have a bad feeling I'm going to have to make some adjustments to the
pack format anyway to cope with HDD-vs-CFQ so will fix that one while
I'm in *there* :-(

> But I don't think it matters anyway, because...
> 
> > 
> > Scott
> > 
> > [0] not sure whether sreadahead triggers itself or not
> 
> ...I believe it does, by virtue of shipping a file in /etc/init.
> 
Yeah, not sure of the dpkg behaviour there - never tested it! :)

Scott
-- 
Scott James Remnant
scott at ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/ubuntu-devel/attachments/20091010/586318c9/attachment.pgp