[ubuntu/karmic] sreadahead 1.0-5 (Accepted)

Matt Zimmerman mdz at ubuntu.com
Sat Oct 10 19:13:32 BST 2009


On Sat, Oct 10, 2009 at 06:10:44PM +0100, Scott James Remnant wrote:
> On Sat, 2009-10-10 at 11:30 +0000, Ubuntu Installer wrote:
> 
> > sreadahead (1.0-5) karmic; urgency=low
> > 
> >   * Use off_t instead of int for the index used relative to statbuf.st_size
> >     (which is off_t), to prevent an overflow on files >2GB (LP: #414597)
> > 
> > Date: Sat, 10 Oct 2009 12:19:26 +0100
> > Changed-By: Matt Zimmerman <mdz at ubuntu.com>
> > Maintainer: Scott James Remnant <scott at ubuntu.com>
> > https://launchpad.net/ubuntu/karmic/+source/sreadahead/1.0-5
> > 
> Doesn't this result in the pack file format changing?  Did you take care
> to migrate that, or at least forcibly remove it[0] so that the size
> change doesn't result in reading random data after this upgrade.

I don't think it does; it's just a local variable.  There is probably
another bug in there which would require changing the format, but I didn't
go further, because this change got it working properly for me, and if I
tried to fix all of the bugs I found it would have taken all day.

But I don't think it matters anyway, because...

> 
> Scott
> 
> [0] not sure whether sreadahead triggers itself or not

...I believe it does, by virtue of shipping a file in /etc/init.

-- 
 - mdz



More information about the ubuntu-devel mailing list