Feature Request - devscripts / checkbashisms should check for select construct

Colin Watson cjwatson at ubuntu.com
Thu Nov 30 10:40:36 GMT 2006


On Tue, Nov 28, 2006 at 11:12:30AM +0000, James Abley wrote:
> This caught me out when testing some scripts prior to migrating to dash 
> on Ubuntu 6.06. Anyone else think this is a good thing to have?

This seems appropriate for a wishlist bug, yes.

> @@ -103,6 +103,7 @@
>              my $match = '';
>              my @bashism_regexs = (
>                  '(?:^|\s+)function\s+\w+',     # function is useless
> +               '(?:^|\s+)select\s+\w+',     # select is useless

I wouldn't say "select is useless". The comment "function is useless" is
there because the bash syntax is "[function] name ()" - i.e. you can
either say "function name ()" or "name ()" so you might as well just
omit the bash-specific keyword. I would just say "select is not POSIX"
or something like that.

Cheers,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]



More information about the ubuntu-devel mailing list