[Merge] ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master

[Gunnar Hjalmarsson]

Gunnar Hjalmarsson has proposed merging ~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.

Requested reviews:
  Iain Lane (laney)
Related bugs:
  Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus input method ignored in live session"
  https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1786344

For more details, see:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368657

An attempt with calling add_ibus_sources_from_locale() unconditionally during the first run of the maybe_convert_old_settings() function.

While this results in a slightly more complex patch, I suppose it's better conceptually, since we don't introduce a dependency of a stamp file belonging to some other package.

There is also an extra bonus (at least I think it is a bonus): When doing e.g. a Chinese or Japanese install, and unlike before, the IBus IM is active instantly at first login. That is, instead of:

[('xkb', 'cn'), ('ibus', 'libpinyin')]

in sources, libpinyin is now the first source:

[('ibus', 'libpinyin'), ('xkb', 'cn')]
-- 
Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4836 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-desktop/attachments/20190611/2e4cd1bd/attachment-0001.diff>