Removing the Ubuntu patch for "Add to panel" dialog

[Manu Cornet]

Hi and Happy New Year to all!

While discussing with the Desktop Team several times in the past, we
considered dropping the Ubuntu-specific patch for the "Add to panel"
dialog, but we had never really reached a conclusion. Since I'm the
one who wrote it, I thought it'd be best if I was the one to suggest
dropping it :-)

Pros:

* Although the patch was good at the time it was written, upstream
took the best of it by adding my "Search as you type" entry (so the
patch has been very useful in convicing them to do that!). Here is a
screenshot:

    http://www.manucornet.net/pub/addto_upstream.png

I think that whether the rest of the patch (making a 2D layout) makes
sense or not is pretty much a matter of taste, but the search box was
really the nice feature.

* Decrease the delta with upstream.

* The code is simpler: my patch used some GnomeCanvas stuff, added a
few files just to get the nice rounded rectangles, etc. The
one-dimensional applet list is just simpler to code and more
straightforward.

* The search box made by people upstream actually works a bit better
than the one I wrote, since it also works in "Application launcher"
part (looking for applications).

Cons:

* We lose the applet categories.

* The two buttons for "Application Launcher" and "Custom Application
Launcher" at the top are nice (but it'll be easy to port them to the
new upstream dialog).

What do you guys think?

I have also seen that the control-center has been redesigned (just
type gnome-control-center in a terminal in feisty), following the work
made by Novell. Do we want to have the same kind of plans for the "Add
to panel" dialog?

Cheers,
Manu