Rejecting indicator-application

[Ken VanDine]

OK, I think I addressed all the issues.  Can you please review it at:

lp:~ubuntu-desktop/indicator-application/ubuntu

Thanks,
--Ken


On Fri, 2009-12-11 at 13:04 +0100, Martin Pitt wrote:
> Hey Ken,
> 
> I reviewed indicator-application, and there are still some fixes to
> do:
> 
> lockers:
> 
> - COPYING.LGPL* are in the diff.gz, they need to be in the upstream release to
>   make the tarball redistributable, and are also in /usr/share/common-licenses/
>   (so no need to ship them in the packaging)
> 
> Bugs (not NEW blockers, but will be for main, and should be fixed anyway):
> - autogen.sh should be in upstream tarball
> - Don't build-dep on scrollkeeper, it's obsolete; use rarian (or -compat);
>   also, it builds with --disable-scrollkeeper?
> - Could use Standards-Version 3.8.3
> - Typo in Vcs-Bzr ("launchpa")
> - Please don't install .a and .la files; let's not further encourage static
>   libraries and libtool madness
> - clean_up_docs.patch: No patch header, and looks weird; why wouldn't you want
>   a link to the latest online documentation? OK if that isn't a template, but 
>   literal boilerplate, and there is no online documentation. (Can we fix the
>   docs upstream then?)
> 
> Thanks,
> 
> Martin