[Merge] lp:~dan-prince/glance/ubuntu-glance-split into lp:~openstack-ubuntu-packagers/glance/ubuntu

Soren Hansen soren at linux2go.dk
Fri Dec 9 14:07:23 UTC 2011


Review: Needs Fixing

The Maintainer: field should only list one person. Actually, we should change it to point to: openstack-packaging at lists.ubuntu.com. Can you do that, please?

glance-api.glance-api.upstart is unnecessary. Just call it glance-api.upstart. It was only called glance.glance-api.upstart to begin with because the glance (binary) package shipped two upstart jobs. Now that each of glance-{api,registry} only ships one upstart job, just call it glance-{api,registry}.upstart.

A maintainer script with only "#DEBHELPER#" in it is redundant. Just get rid of it.

#DEBHELPER# is a placeholder used if you provide your own scripts. It gets replaced with the stuff from debhelper. If you don't want to add anything custom, just don't ship a script.

We need to handle the upgrade scenario better, too.
-- 
https://code.launchpad.net/~dan-prince/glance/ubuntu-glance-split/+merge/85059
Your team OpenStack Ubuntu packagers is subscribed to branch lp:~openstack-ubuntu-packagers/glance/ubuntu.



More information about the Openstack-packaging mailing list