Quick approval

Alexandros Frantzis alexandros.frantzis at canonical.com
Tue Jul 9 07:16:52 UTC 2013

On Tue, Jul 09, 2013 at 01:19:21PM +0800, Daniel van Vugt wrote:
> All,
> I noticed some people are regularly only waiting for a single
> approval on their MPs and then top-approve themselves.
> I think top-approving your own MPs is OK if there's already two or
> more reviews from others, and it's been idle for a few days. But
> merging with only one real review, on proposals which are not time
> critical, is probably not ideal. I think we should always be waiting
> for at least a second review, unless it's a time critical issue.
> Maybe others in mir-team disagree?
> - Daniel

I agree. If an MP is trivial (a typo, a simple fix), I think it's OK for
the first *reviewer* to top-approve it.


More information about the Mir-devel mailing list